Community ISO maintenance and build issues - 2

[grizzler]

It would, but why bother using geoip-database-contrib at all? The geoip-database package has been around for years. It's available in stretch, even goes back as far as wheezy.

Because geoip-database-contrib is a download script:

I see. Then the real replacement would probably be geoipupdate:
https://dev.maxmind.com/geoip/geoipupdate/
https://tracker.debian.org/pkg/geoipupdate
https://tracker.debian.org/pkg/libmaxminddb

Perhaps for the installer it's overkill to have the contrib package.

Wouldn't you still need something to keep the database up-to-date?

[kurotsugi]

btw, is it really safe to run deborphan there? in my experience autoremove is enough. OTOH deborphan could became quite nasty. the system would still works, but since deborphan works deeper, some recommended packages sometimes got removed, which leads to loss of some functionalities.

[Arjen Balfoort]

I've adapted live-installer-3 to use geoipupdate instead of geoip-database-contrib.
I had to manually create /etc/GeoIP.conf:

Code: Select all

# The following AccountID and LicenseKey are required placeholders.
# For geoipupdate versions earlier than 2.5.0, use UserId here instead of AccountID.
UserId 0
LicenseKey 000000000000

# Include one or more of the following edition IDs:
# * GeoLite2-City - GeoLite 2 City
# * GeoLite2-Country - GeoLite2 Country
# For geoipupdate versions earlier than 2.5.0, use ProductIds here instead of EditionIDs.
ProductIds GeoLite2-City GeoLite2-Country

In SolydXK-10:

Code: Select all

# The following AccountID and LicenseKey are required placeholders.
# For geoipupdate versions earlier than 2.5.0, use UserId here instead of AccountID.
AccountID 0
LicenseKey 000000000000

# Include one or more of the following edition IDs:
# * GeoLite2-City - GeoLite 2 City
# * GeoLite2-Country - GeoLite2 Country
# For geoipupdate versions earlier than 2.5.0, use ProductIds here instead of EditionIDs.
EditionIDs GeoLite2-City GeoLite2-Country

For this reason I've also adapted the cleanup.sh script of solydxk-constructor. It generates this .conf file depending the version of geoipupdate.

[grizzler]

Great! I've also updated my ISO build scripts.

Now to figure out why upgrading the lot still wants to remove the installer...

Edit
Curious. You need to install geoip-database separately first, or apt will get seriously confused.

P.S.
You do know about dpkg --compare-versions, don't you? The relevant bit in my script is:

Code: Select all

if dpkg --compare-versions "$InstalledVersion" lt "2.5.0"; then
	ID1=UserId
	ID2=ProductIds
else
	ID1=AccountID
	ID2=EditionIDs
fi
cat >"$RootPath/etc/GeoIP.conf" <<-EOT
# The following AccountID and LicenseKey are required placeholders.
# For geoipupdate versions earlier than 2.5.0, use UserId here instead of AccountID.
$ID1 0
LicenseKey 000000000000

# Include one or more of the following edition IDs:
# * GeoLite2-City - GeoLite 2 City
# * GeoLite2-Country - GeoLite2 Country
# For geoipupdate versions earlier than 2.5.0, use ProductIds here instead of EditionIDs.
$ID2 GeoLite2-City GeoLite2-Country
EOT
ChrootRun /usr/bin/geoipupdate

Where $InstalledVersion is set by a function that checks whether the specified package is installed (in a chroot if $RootPath is set), $RootPath points to the root in the ISO's chroot and ChrootRun runs the specified binary in that chroot.

[Arjen Balfoort]

Great! I've also updated my ISO build scripts.

Now to figure out why upgrading the lot still wants to remove the installer...

Edit
Curious. You need to install geoip-database separately first, or apt will get seriously confused.

Yes, I thought it was just me...

P.S.
You do know about dpkg --compare-versions, don't you?

No, I didn't. I never had to use that in bash, just in Python. Thanks, I'll update the cleanup script with your code.

[Arjen Balfoort]

...but the live installer is not working:

Code: Select all

Error Opening file /usr/share/GeoIP/GeoIPCity.dat

I'll have to look into that.

[Arjen Balfoort]

That was easier than I thought. Use python3-geoip2: https://geoip2.readthedocs.io/en/latest/
Updated live-installer-3 in repository.

[Arjen Balfoort]

Don't forget to adapt boot/live/filesystem.packages-remove:

Code: Select all

live-installer*
python3-geoip2
geoipupdate
live-boot
live-boot-initramfs-tools
live-config
live-config-sysvinit
live-config-systemd
live-build
live-tools
gdisk
gparted
jfsutils
libgtkmm-2.4*
xfsprogs
libreadline5
streamer
isoquery
libparted-fs-resize0

[grizzler]

Hadn't looked at that yet. Thanks.

By the way, I'm leaving gdisk out of that list. There was a good reason, but I'm too busy to check right now...

Just remembered. This was it: https://forums.solydxk.com/viewtopic.ph ... isk#p67172